[coreboot-gerrit] Change in coreboot[master]: [WIP]soc/intel/common/block: Add Intel PMC support

Bora Guvendik (Code Review) gerrit at coreboot.org
Tue May 2 19:49:57 CEST 2017


Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/19349 )

Change subject: [WIP]soc/intel/common/block: Add Intel PMC support
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/19349/1//COMMIT_MSG
Commit Message:

PS1, Line 7: [WIP]
remove this


https://review.coreboot.org/#/c/19349/1/src/soc/intel/common/block/pmc/Kconfig
File src/soc/intel/common/block/pmc/Kconfig:

PS1, Line 4: PMC
please describe what PMC stands for


https://review.coreboot.org/#/c/19349/1/src/soc/intel/common/block/pmc/pmc.c
File src/soc/intel/common/block/pmc/pmc.c:

PS1, Line 31:         
use tabs


-- 
To view, visit https://review.coreboot.org/19349
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3d96fc23a98c30e8ea0969a7be09d217eeaa889
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list