[coreboot-gerrit] Change in coreboot[master]: mainboard/google/reef: turn off DMIC_CLK_B1 in S0ix

Martin Roth (Code Review) gerrit at coreboot.org
Wed Mar 29 05:17:33 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19018 )

Change subject: mainboard/google/reef: turn off DMIC_CLK_B1 in S0ix
......................................................................


mainboard/google/reef: turn off DMIC_CLK_B1 in S0ix

Wake On Voice stream capture configuration is mono. It is sufficient
to keep DMIC_CLK_A1 on in S0ix; so, turning off DMIC_CLK_B1.
Power saving should be visible in the boards which has more
than one DMIC connected.

BUG=None
BRANCH=None
TEST=WoV and quad channel DMIC capture works

Change-Id: Ic46d4c7b30b945eba47a05d78386f48e4a675a03
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Reviewed-on: https://review.coreboot.org/19018
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Tested-by: build bot (Jenkins)
---
M src/mainboard/google/reef/variants/baseboard/gpio.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  Venkateswarlu V Vinjamuri: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/reef/variants/baseboard/gpio.c b/src/mainboard/google/reef/variants/baseboard/gpio.c
index c572b1e..a4cef02 100644
--- a/src/mainboard/google/reef/variants/baseboard/gpio.c
+++ b/src/mainboard/google/reef/variants/baseboard/gpio.c
@@ -222,8 +222,7 @@
 	/* DMIC or I2S4 */
 	/* AVS_DMIC_CLK_A1 */
 	PAD_CFG_NF_IOSSTATE(GPIO_79, NATIVE, DEEP, NF1, IGNORE),
-	/* AVS_DMIC_CLK_B1 */
-	PAD_CFG_NF_IOSSTATE(GPIO_80, NATIVE, DEEP, NF1, IGNORE),
+	PAD_CFG_NF(GPIO_80, NATIVE, DEEP, NF1), /* AVS_DMIC_CLK_B1 */
 	PAD_CFG_NF(GPIO_81, NATIVE, DEEP, NF1),	/* AVS_DMIC_DATA_1 */
 	PAD_CFG_GPI(GPIO_82, DN_20K, DEEP),	 /* unused -- strap */
 	PAD_CFG_NF(GPIO_83, NATIVE, DEEP, NF1), /* AVS_DMIC_DATA_2 */

-- 
To view, visit https://review.coreboot.org/19018
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic46d4c7b30b945eba47a05d78386f48e4a675a03
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list