[coreboot-gerrit] Change in coreboot[master]: chromeos / broadwell / jecht: Make save_chromeos_gpios() jec...

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18981 )

Change subject: chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18981/2/src/soc/intel/broadwell/romstage/romstage.c
File src/soc/intel/broadwell/romstage/romstage.c:

Line 41: void __attribute__((weak)) save_chromeos_gpios(void)
> I'd just nuke this from broadwell entirely and implement it in ject mainboa
Okay, will do (but I don't have a Jecht to test this on).


-- 
To view, visit https://review.coreboot.org/18981
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes