[coreboot-gerrit] Change in coreboot[master]: chromeos / broadwell / jecht: Make save_chromeos_gpios() jec...

Julius Werner (Code Review) gerrit at coreboot.org
Tue Mar 28 02:09:57 CEST 2017


Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18981

to look at the new patch set (#3).

Change subject: chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific
......................................................................

chromeos / broadwell / jecht: Make save_chromeos_gpios() jecht-specific

This callback was only required for a single mainboard, and it can
easily be moved to mainboard-specific code. This patch removes it from
the global namespace and isolates it to the Jecht board. (This makes
it easier to separate vboot and chromeos code in a later patch.)

Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/jecht/chromeos.c
M src/mainboard/google/jecht/onboard.h
M src/mainboard/google/jecht/romstage.c
M src/soc/intel/broadwell/romstage/romstage.c
M src/vendorcode/google/chromeos/chromeos.c
M src/vendorcode/google/chromeos/chromeos.h
6 files changed, 7 insertions(+), 12 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/18981/3
-- 
To view, visit https://review.coreboot.org/18981
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list