[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Sapphire Pure Platinum H61

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18564 )

Change subject: mainboard: Add Sapphire Pure Platinum H61
......................................................................


Patch Set 13:

(1 comment)

https://review.coreboot.org/#/c/18564/13//COMMIT_MSG
Commit Message:

PS13, Line 47: * If an external card is inserted and the option
             :     ONBOARD_VGA_IS_PRIMARY is not enabled, the internal GPU
             :     disappears completely from the PCI bus.
> IMO, this is completely an unexpected behaviour, as many users (me included
I'm not entirely sure IGD can work when it's not PRIMARY. uma resources (somewhat accidentally) are still allocated on sandy/ivy bridge, so just removing that line in disable_peg() should provide an answer if this is possible.


-- 
To view, visit https://review.coreboot.org/18564
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aca2cfc4708c1728ae03ee4f6bc59d976c28a0
Gerrit-PatchSet: 13
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes