[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Sapphire Pure Platinum H61

[Nicola Corna (Code Review)]

Nicola Corna has posted comments on this change. ( https://review.coreboot.org/18564 )

Change subject: mainboard: Add Sapphire Pure Platinum H61
......................................................................


Patch Set 13:

(1 comment)

> Nice that you hooked up libgfxinit!

Unfortunately I've just noticed that, with libgfxinit, the GPU doesn't work after a S3 resume.

 > Please provide raminit logs for both failing and working case. Did you try the pending ivybridge raminit patches? They might increase raminit stability.

Unfortunately I can't reproduce the working case, but I can provide you the log of a failed raminit, as soon as I obtain a USB debugger.

https://review.coreboot.org/#/c/18564/13//COMMIT_MSG
Commit Message:

PS13, Line 47: * If an external card is inserted and the option
             :     ONBOARD_VGA_IS_PRIMARY is not enabled, the internal GPU
             :     disappears completely from the PCI bus.
> This is the result of the combination of disable_peg() in nb/sandybridge/no
IMO, this is completely an unexpected behaviour, as many users (me included) use both the GPUs. The OEM bios didn't show the integrated GPU as well, which led me to think that my integrated GPU was dead.

I'll give a look at the code and add a NVRAM switch if I can.


-- 
To view, visit https://review.coreboot.org/18564
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aca2cfc4708c1728ae03ee4f6bc59d976c28a0
Gerrit-PatchSet: 13
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes