[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945: Fix errors found by checkpatch.pl
Jonathan Neuschäfer (Code Review)
gerrit at coreboot.org
Fri Mar 24 16:34:03 CET 2017
Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/18704 )
Change subject: nb/intel/i945: Fix errors found by checkpatch.pl
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/18704/3/src/northbridge/intel/i945/debug.c
File src/northbridge/intel/i945/debug.c:
PS3, Line 90: if (status < 0)
: printk(BIOS_DEBUG, "bad device: %02x\n", -status);
: break;
This part is wrong. See https://review.coreboot.org/18971 for a fix
--
To view, visit https://review.coreboot.org/18704
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dd40e73d4a4c091c5ce1f49bbf9ab4d013d7af
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list