[coreboot-gerrit] Change in coreboot[master]: driver/intel/mipi_camera: Add MIPI CSI camera SSDT generator

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/18967 )

Change subject: driver/intel/mipi_camera: Add MIPI CSI camera SSDT generator
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/18967/1//COMMIT_MSG
Commit Message:

PS1, Line 9: Add SSDT generator for MIPI CSI camera which will generate required
           : SSDB and CLDB structures for device specific data and PWDB structure
           : for power sequencing data which are used by the Intel kernel drivers.
           : * SSDB: Sensor specific database for camera sensor.
           : * CLDB: Control logic database for camera PMIC.
           : * PWDB: Power database for all the camera devices.
           : * CAMD: ACPI object to specify the camera device type.
Add SSDT generator for MIPI CSI camera to create ACPI objects used by the Intel kernel drivers.
* SSDB: Sensor specific database for camera sensor.
* CLDB: Control logic database for camera PMIC.
* PWDB: Power database for all the camera devices.
* CAMD: ACPI object to specify the camera device type.


PS1, Line 17: b:36580624
b/36580624


https://review.coreboot.org/#/c/18967/1/src/drivers/intel/mipi_camera/chip.h
File src/drivers/intel/mipi_camera/chip.h:

PS1, Line 19: #include <arch/acpi_device.h>
not required here. include it in camera.c


-- 
To view, visit https://review.coreboot.org/18967
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9e56d12b64081897613bf1c7abcdf915470b99
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-HasComments: Yes