[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Code clean up to use soc/intel/common/...

Subrata Banik (Code Review) gerrit at coreboot.org
Wed Mar 22 17:32:03 CET 2017


Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18555 )

Change subject: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu
......................................................................


Patch Set 17:

(1 comment)

https://review.coreboot.org/#/c/18555/17/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:

Line 274
> The NEM completely used the L2 and no other caching was available aside fro
got it. but the reason i have added SOC_INTEL_COMMON_BLOCK_CAR in order to avoid multiple option to choice cache_as_ram.S file inside makefile.inc.

now if we choose only respective car option then we need to address all of these inside single makefile


-- 
To view, visit https://review.coreboot.org/18555
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7
Gerrit-PatchSet: 17
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list