[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Code clean up to use soc/intel/common/...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18555 )

Change subject: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu
......................................................................


Patch Set 17:

(1 comment)

https://review.coreboot.org/#/c/18555/17/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:

Line 274
> You've completely lost the ability for the user to choose their CAR impleme
I guess CQOS and NEM are mutually exclusive and its up to SOC to decide which support we want to enable between NEM and CQOS, except few early soc parts during SOC PO, i don't see any reason not to use CQOS directly. 

I wonder what was the case earlier w/o this patch it was also default CAR_CQOS getting selected? isn't it? 

Do you have some other recomendation to address this problem, i guess 1 POR/tetsed config should be good to select from day 1?


-- 
To view, visit https://review.coreboot.org/18555
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7
Gerrit-PatchSet: 17
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes