[coreboot-gerrit] Change in coreboot[master]: poppy: Enable s0ix

[Naresh Solanki (Code Review)]

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/18880 )

Change subject: poppy: Enable s0ix
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18880/1/src/mainboard/google/poppy/devicetree.cb
File src/mainboard/google/poppy/devicetree.cb:

PS1, Line 7: register "s0ix_enable" = "1"
> > >But isn't S0ix a property of the OS itself? Why do we need >to
With this enabling
The command for s0ix:
echo freeze > /sys/power/state
successfully puts the device in s0ix, i.e., SLP_S0 is asserted.

For S3:
echo mem > /sys/power/state
successfully works irrespective of the patch.

Its upto OS to decide what to use. Either S0ix or S3.

Definitely S3 saves more power than S0ix but resume time is slightly higher than that of S0ix.


-- 
To view, visit https://review.coreboot.org/18880
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I721cb3a52c2b9bc79729267eb28af4e18eff654a
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-HasComments: Yes