[coreboot-gerrit] Change in coreboot[master]: poppy: Enable s0ix

[Naresh Solanki (Code Review)]

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/18880 )

Change subject: poppy: Enable s0ix
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18880/1/src/mainboard/google/poppy/devicetree.cb
File src/mainboard/google/poppy/devicetree.cb:

PS1, Line 7: register "s0ix_enable" = "1"
> > Enabling this will allow OS to use s0ix as well
>But isn't S0ix a property of the OS itself? Why do we need >to have a config for that within the firmware?
This is how the approach have been, refer 
"src/soc/intel/skylake/acpi.c"
If there is real need then we can go for a change.


>Did you try running suspend_stress_test? It would be good >to get a datapoint of at least 1000 suspend resume cycles >for S3
I've tested for 100+ cycles. Will do it for 1000 as well.


-- 
To view, visit https://review.coreboot.org/18880
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I721cb3a52c2b9bc79729267eb28af4e18eff654a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-HasComments: Yes