[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add alternate method for including amdfw

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18435 )

Change subject: amd/pi/hudson: Add alternate method for including amdfw
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/18435/5/src/southbridge/amd/pi/hudson/Kconfig
File src/southbridge/amd/pi/hudson/Kconfig:

Line 224: config AMDFW_OUTSIDE_CBFS
> This is outside if SOUTHBRIDGE_AMD_PI_xxx ... endif
>This is outside if SOUTHBRIDGE_AMD_PI_xxx ... endif

Hmm, it looks like HUDSON_UART is also outside but it has a "depends on".  I'll move this item.

>Also I think one of the binaryPI platforms did not have PSP

That doesn't seem like a problem to me.  This would only be selected where it's needed.

>Additionally one must understand that CBFS cannot cover all of SPI flash...

I assume you mean because of the CBFS metadata required.  The boards currently default to a CBFS size equal to flash size.  So maybe what you're getting at is a board will need to manually set a reduced CBFS size.


https://review.coreboot.org/#/c/18435/5/src/southbridge/amd/pi/hudson/Makefile.inc
File src/southbridge/amd/pi/hudson/Makefile.inc:

PS5, Line 268: PHONY+=add_amdfw
> Ok, It looks like this is also a valid way of adding the phony target.
I don't have a preference.  It looks like there are examples of both, including in the same file.


-- 
To view, visit https://review.coreboot.org/18435
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38029bc03e5db260424cca293b1a7bceea4d0d75
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes