[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add alternate method for including amdfw

Martin Roth (Code Review) gerrit at coreboot.org
Tue Mar 21 20:00:40 CET 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/18435 )

Change subject: amd/pi/hudson: Add alternate method for including amdfw
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/18435/5/src/southbridge/amd/pi/hudson/Makefile.inc
File src/southbridge/amd/pi/hudson/Makefile.inc:

PS5, Line 268: PHONY+=add_amdfw
> PHONY: add_amdfw
Ok, It looks like this is also a valid way of adding the phony target.


-- 
To view, visit https://review.coreboot.org/18435
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38029bc03e5db260424cca293b1a7bceea4d0d75
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list