[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Ensure \_SB.LID0 is present before using it

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/18941 )

Change subject: google/chromeec: Ensure \_SB.LID0 is present before using it
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/18941/2/src/ec/google/chromeec/acpi/ec.asl
File src/ec/google/chromeec/acpi/ec.asl:

PS2, Line 29: External (\_SB.LID0, DeviceObj)
This might be guarded by !EC_ENABLE_LID_SWITCH, though it doesn't really matter in the end.


PS2, Line 169: Store (LIDS, \LIDS)
> Still this seems a bit inconsistent. We do not have a LID device, but we ar
We should probably just remove \LIDS usage everywhere, at least on chrome ec devices.

But, if the platform doesn't enable the lid events it will never execute this anyway.


-- 
To view, visit https://review.coreboot.org/18941
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes