[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Ensure \_SB.LID0 is present before using it

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue Mar 21 20:26:22 CET 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18941 )

Change subject: google/chromeec: Ensure \_SB.LID0 is present before using it
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18941/2/src/ec/google/chromeec/acpi/ec.asl
File src/ec/google/chromeec/acpi/ec.asl:

PS2, Line 169: Store (LIDS, \LIDS)
Still this seems a bit inconsistent. We do not have a LID device, but we are storing LIDS.


-- 
To view, visit https://review.coreboot.org/18941
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list