[coreboot-gerrit] Change in coreboot[master]: mainboards: Don’t select `CONSOLE POST`

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18878 )

Change subject: mainboards: Don’t select `CONSOLE_POST`
......................................................................


mainboards: Don’t select `CONSOLE_POST`

Currently, it’s impossible for the user to select `NO_POST`, for boards
selecting `CONSOLE_POST` in their config.

```
warning: (BOARD_SPECIFIC_OPTIONS) selects CONSOLE_POST which has unmet
direct dependencies (VENDOR_SIEMENS && BOARD_SIEMENS_MC_BDX1 || !NO_POST)
```

This is currently done for Intel Camelback Mountain and Siemens MC-BDX1.

Selecting the option `CONSOLE_POST` in board specific configuration is
not a good idea, as this should be user configurable over Kconfig, and
also the tree-wide defaults should be the same for these options.

Kconfig is different, as commit 97535558f1 (mainboard/{google,intel}:
Change config option selection) only touch the Intel board.

Change-Id: I91c1e0cb92ed218b6bbc7c33759b91f748cf6f51
Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/18878
Tested-by: build bot (Jenkins)
Reviewed-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/mainboard/intel/camelbackmountain_fsp/Kconfig
M src/mainboard/siemens/mc_bdx1/Kconfig
2 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Werner Zeh: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/mainboard/intel/camelbackmountain_fsp/Kconfig b/src/mainboard/intel/camelbackmountain_fsp/Kconfig
index 9e71a08..3d29e2e 100644
--- a/src/mainboard/intel/camelbackmountain_fsp/Kconfig
+++ b/src/mainboard/intel/camelbackmountain_fsp/Kconfig
@@ -10,7 +10,6 @@
 	select INTEGRATED_UART if FSP_PACKAGE_DEFAULT
 	select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
 	select SERIRQ_CONTINUOUS_MODE
-	select CONSOLE_POST
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/siemens/mc_bdx1/Kconfig b/src/mainboard/siemens/mc_bdx1/Kconfig
index e679eb5..f64b22b 100644
--- a/src/mainboard/siemens/mc_bdx1/Kconfig
+++ b/src/mainboard/siemens/mc_bdx1/Kconfig
@@ -38,10 +38,6 @@
 	hex
 	default 0x1000000
 
-config CONSOLE_POST
-	bool
-	default y
-
 config INTEGRATED_UART
 	bool
 	default n

-- 
To view, visit https://review.coreboot.org/18878
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91c1e0cb92ed218b6bbc7c33759b91f748cf6f51
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins)