[coreboot-gerrit] Change in coreboot[master]: mainboards: Don’t select `CONSOLE POST`

Martin Roth (Code Review) gerrit at coreboot.org
Tue Mar 21 17:20:42 CET 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/18878 )

Change subject: mainboards: Don’t select `CONSOLE_POST`
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18878/1//COMMIT_MSG
Commit Message:

PS1, Line 13:  direct
> Done, but I actually don’t agree, as that’s a paste from the command line.
Thanks, I don't think it matters where the line came from.  If the command line was 1000 characters long, would it still be not to wrap it? Where is the exception documented?  Look at patch set 1 in gerrit and the scroll bar.  Having un-wrapped lines in the commit message is always bad in my opinion.


-- 
To view, visit https://review.coreboot.org/18878
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1e0cb92ed218b6bbc7c33759b91f748cf6f51
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list