[coreboot-gerrit] Change in coreboot[master]: tint: Add USB support

Martin Roth (Code Review) gerrit at coreboot.org
Sun Mar 19 21:38:27 CET 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18766 )

Change subject: tint: Add USB support
......................................................................


tint: Add USB support

Enable the USB during the initialization of tint. Without it USB
keyboards don't work, which makes this payload pointless on
systems where a PS/2 keyboard port isn't available.

Based on I98f0ccdb19d6b195572941cf87ce3221f57db7c5 (tint and
nvramcui: enable USB, update tint to 0.04+nmu1 with changes) [1]

[1] https://review.coreboot.org/17507/

Change-Id: Iaa8dfac0301ef19a2d76a0975d025b00e7f3807b
Signed-off-by: Nicola Corna <nicola at corna.info>
Reviewed-on: https://review.coreboot.org/18766
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M payloads/external/tint/libpayload_tint.patch
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/payloads/external/tint/libpayload_tint.patch b/payloads/external/tint/libpayload_tint.patch
index c261fc1..b5592dd 100644
--- a/payloads/external/tint/libpayload_tint.patch
+++ b/payloads/external/tint/libpayload_tint.patch
@@ -823,7 +823,16 @@
  }
  
            /***************************************************************************/
-@@ -663,8 +680,15 @@ int main (int argc,char *argv[])
+@@ -561,6 +578,8 @@ int main (int argc,char *argv[])
+    int ch;
+    engine_t engine;
+    /* Initialize */
++   if (IS_ENABLED(CONFIG_LP_USB))
++      usb_initialize();
+    rand_init ();							/* must be called before engine_init () */
+    engine_init (&engine,score_function);	/* must be called before using engine.curshape */
+    finished = shownext = FALSE;
+@@ -663,8 +682,15 @@
     if (ch != 'q')
  	 {
  		showplayerstats (&engine);

-- 
To view, visit https://review.coreboot.org/18766
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa8dfac0301ef19a2d76a0975d025b00e7f3807b
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list