[coreboot-gerrit] Change in coreboot[master]: arch/x86: Fix most of remaining issues detected by checkpatch

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18865 )

Change subject: arch/x86: Fix most of remaining issues detected by checkpatch
......................................................................


Patch Set 1:

> And I am waiting for someone to answer why checkpatch.pl claims
 > asmlinkage as a storage-class in the first place.

Well, since it came from the linux kernel, you could ask there.  Or you could look in the checkpatch source, the same as any of the others of us will need to do.

Personally, I think it's confused.

Lee, can you separate out the asmlinkage stuff from the rest of this patch, assuming that there's no objection the other pieces of the patch.  I guess the asmlinkage parts can wait until we look through the script and figure out the issue.

-- 
To view, visit https://review.coreboot.org/18865
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39d49790c5eaeedec5051e1fab0b1279275f6e7f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No