[coreboot-gerrit] Change in coreboot[master]: arch/x86: Fix most of remaining issues detected by checkpatch

[Lee Leahy (Code Review)]

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/18865 )

Change subject: arch/x86: Fix most of remaining issues detected by checkpatch
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/18865/1/src/arch/x86/acpi_s3.c
File src/arch/x86/acpi_s3.c:

Line 205: 	u32 backup_target, u32 backup_size) = (void *)WAKEUP_BASE;
> Since I was late on commenting this before submit here:
checkpatch is indicating that this be specified at the beginning of the line.


Line 244: void __attribute__((weak)) mainboard_suspend_resume(void)
> It appears coreboot proper mostly followed this placement for function attr
I am fixing the issues pointed out by checkpatch.  Feel free to work with Martin Roth to get checkpatch to address other coding standard items or inconsistencies.  Or better yet, pick a directory and updated it so that it passes checkpatch.


-- 
To view, visit https://review.coreboot.org/18865
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39d49790c5eaeedec5051e1fab0b1279275f6e7f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes