[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add cache as ram init and teardown code

gerrit code review gerrit at coreboot.org
Thu Mar 16 14:55:49 CET 2017


>From Subrata Banik <subrata.banik at intel.com>:

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18381 )

Change subject: soc/intel/common/block: Add cache as ram init and teardown code
......................................................................


Patch Set 23:

(1 comment)

https://review.coreboot.org/#/c/18381/23/src/soc/intel/common/block/cpu/Kconfig
File src/soc/intel/common/block/cpu/Kconfig:

Line 27: 	default n
> I understand that how you have it written now would make it a recursive dep
Got your point, i want to limit the number of Kconfig for one IP module, in that way for a single CAR module, i may need to have 2 Kconfig, 1. SOC_INTEL_COMMON_BLOCK_CAR 2. NEM/CQOS/NEM_ENHANCE

If you see, for SA patch, i have done something like that, and ensure from SoC we are selecting both else added one #ERROR. if you think that should be the case here as well, we can implement that.


-- 
To view, visit https://review.coreboot.org/18381
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd0c3e3ca81a3d283d5f1da115222a222e6b157
Gerrit-PatchSet: 23
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list