[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Fix spacing issues

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Fri Mar 10 17:54:16 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18744

-gerrit

commit 7f8b90a8d4c8227623ec669555072bc6393849f2
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Fri Mar 10 08:40:18 2017 -0800

    drivers/intel/fsp2_0: Fix spacing issues
    
    Fix the following errors detected by checkpatch.pl:
    
    ERROR: space prohibited before that close parenthesis ')'
    ERROR: space required before the open parenthesis '('
    ERROR: space prohibited before open square bracket '['
    ERROR: spaces required around that ':' (ctx:VxE)
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I085aaaa9e276c60eded6edf3be0325ed2402702a
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/drivers/intel/fsp2_0/header_display.c | 6 +++---
 src/drivers/intel/fsp2_0/hob_display.c    | 4 ++--
 src/drivers/intel/fsp2_0/memory_init.c    | 2 +-
 src/drivers/intel/fsp2_0/util.c           | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/header_display.c b/src/drivers/intel/fsp2_0/header_display.c
index 543c075..f10e2fa 100644
--- a/src/drivers/intel/fsp2_0/header_display.c
+++ b/src/drivers/intel/fsp2_0/header_display.c
@@ -28,7 +28,7 @@ void fsp_print_header_info(const struct fsp_header *hdr)
 
 	revision.val = hdr->fsp_revision;
 
-	printk(BIOS_SPEW, "Spec version: v%u.%u\n", (hdr->spec_version >> 4 ),
+	printk(BIOS_SPEW, "Spec version: v%u.%u\n", (hdr->spec_version >> 4),
 							hdr->spec_version & 0xf);
 	printk(BIOS_SPEW, "Revision: %u.%u.%u, Build Number %u\n",
 							revision.rev.major,
@@ -36,8 +36,8 @@ void fsp_print_header_info(const struct fsp_header *hdr)
 							revision.rev.revision,
 							revision.rev.bld_num);
 	printk(BIOS_SPEW, "Type: %s/%s\n",
-			(hdr->component_attribute & 1 ) ? "release" : "debug",
-			(hdr->component_attribute & 2 ) ? "test" : "official");
+			(hdr->component_attribute & 1) ? "release" : "debug",
+			(hdr->component_attribute & 2) ? "test" : "official");
 	printk(BIOS_SPEW, "image ID: %s, base 0x%lx + 0x%zx\n",
 		hdr->image_id, hdr->image_base, hdr->image_size);
 	printk(BIOS_SPEW, "\tConfig region        0x%zx + 0x%zx\n",
diff --git a/src/drivers/intel/fsp2_0/hob_display.c b/src/drivers/intel/fsp2_0/hob_display.c
index c56075b..7257aec 100644
--- a/src/drivers/intel/fsp2_0/hob_display.c
+++ b/src/drivers/intel/fsp2_0/hob_display.c
@@ -17,7 +17,7 @@ struct hob_type_name {
 	const char *name;
 } __attribute__((packed));
 
-static const struct hob_type_name hob_type_names [] = {
+static const struct hob_type_name hob_type_names[] = {
 	{ HOB_TYPE_HANDOFF, "HOB_TYPE_HANDOFF" },
 	{ HOB_TYPE_MEMORY_ALLOCATION, "HOB_TYPE_MEMORY_ALLOCATION" },
 	{ HOB_TYPE_RESOURCE_DESCRIPTOR, "HOB_TYPE_RESOURCE_DESCRIPTOR" },
@@ -190,7 +190,7 @@ void fsp_display_hobs(void)
 		/* Display the HOB header */
 		printk(BIOS_SPEW, "0x%p, 0x%08x bytes: %s\n", hob, hob->length,
 			fsp_get_hob_type_name(hob));
-		switch(hob->type) {
+		switch (hob->type) {
 		default:
 			soc_display_hob(hob);
 			break;
diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c
index e9386d6..46dd2ef 100644
--- a/src/drivers/intel/fsp2_0/memory_init.c
+++ b/src/drivers/intel/fsp2_0/memory_init.c
@@ -228,7 +228,7 @@ static void fsp_fill_mrc_cache(FSPM_ARCH_UPD *arch_upd, bool s3wake,
 	/* MRC cache found */
 	arch_upd->NvsBufferPtr = data;
 	arch_upd->BootMode = s3wake ?
-		FSP_BOOT_ON_S3_RESUME:
+		FSP_BOOT_ON_S3_RESUME :
 		FSP_BOOT_ASSUMING_NO_CONFIGURATION_CHANGES;
 	printk(BIOS_SPEW, "MRC cache found, size %zx bootmode:%d\n",
 				region_device_sz(&rdev), arch_upd->BootMode);
diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c
index 7453b59..f84d69c 100644
--- a/src/drivers/intel/fsp2_0/util.c
+++ b/src/drivers/intel/fsp2_0/util.c
@@ -107,7 +107,7 @@ void fsp_handle_reset(uint32_t status)
 
 	printk(BIOS_SPEW, "FSP: handling reset type %x\n", status);
 
-	switch(status) {
+	switch (status) {
 	case FSP_STATUS_RESET_REQUIRED_COLD:
 		hard_reset();
 		break;



More information about the coreboot-gerrit mailing list