[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Add space before *

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Fri Mar 10 17:54:15 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18743

-gerrit

commit 5a9bc367652e396cf5a212bda291c7cb72d72158
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Fri Mar 10 08:33:16 2017 -0800

    drivers/intel/fsp2_0: Add space before *
    
    Fix the following error detected by checkpatch.pl:
    
    ERROR: "(foo*)" should be "(foo *)"
    
    False positives are generated by checkpatch for the following condition
    which is not properly detecting the variable type:
    ERROR: need consistent spacing around '*' (ctx:WxV)
    The false positives are found in debug.h and upd_display.c
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I0e871d64544ebf5eacbae46466cf7aefbfa701eb
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/drivers/intel/fsp2_0/notify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c
index 09d335f..63ad37a 100644
--- a/src/drivers/intel/fsp2_0/notify.c
+++ b/src/drivers/intel/fsp2_0/notify.c
@@ -27,7 +27,7 @@ static void fsp_notify(enum fsp_notify_phase phase)
 	if (!fsps_hdr.notify_phase_entry_offset)
 		die("Notify_phase_entry_offset is zero!\n");
 
-	fspnotify = (void*) (fsps_hdr.image_base +
+	fspnotify = (void *) (fsps_hdr.image_base +
 			    fsps_hdr.notify_phase_entry_offset);
 	fsp_before_debug_notify(fspnotify, &notify_params);
 



More information about the coreboot-gerrit mailing list