[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: Fix position of storage class
Lee Leahy (leroy.p.leahy@intel.com)
gerrit at coreboot.org
Thu Mar 9 20:21:05 CET 2017
Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18726
-gerrit
commit 166c1419bbcc0ef3c4db829bfcd62432e77e8198
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Thu Mar 9 10:38:09 2017 -0800
soc/intel/apollolake: Fix position of storage class
Fix the following error and warning detected by checkpatch.pl:
ERROR: inline keyword should sit between storage class and type
WARNING: storage class should be at the beginning of the declaration
TEST=Build for reef
Change-Id: I2ed418cc3b4a989eb1101013944169429bf147c2
Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
src/soc/intel/apollolake/bootblock/bootblock.c | 2 +-
src/soc/intel/apollolake/include/soc/iosf.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/soc/intel/apollolake/bootblock/bootblock.c b/src/soc/intel/apollolake/bootblock/bootblock.c
index f519463..cdf3acf 100644
--- a/src/soc/intel/apollolake/bootblock/bootblock.c
+++ b/src/soc/intel/apollolake/bootblock/bootblock.c
@@ -49,7 +49,7 @@ static void enable_cmos_upper_bank(void)
iosf_write(IOSF_RTC_PORT_ID, RTC_CONFIG, reg);
}
-void asmlinkage bootblock_c_entry(uint64_t base_timestamp)
+asmlinkage void bootblock_c_entry(uint64_t base_timestamp)
{
device_t dev = NB_DEV_ROOT;
diff --git a/src/soc/intel/apollolake/include/soc/iosf.h b/src/soc/intel/apollolake/include/soc/iosf.h
index 99ed9fc..3c96c58 100644
--- a/src/soc/intel/apollolake/include/soc/iosf.h
+++ b/src/soc/intel/apollolake/include/soc/iosf.h
@@ -30,12 +30,12 @@ static inline void *iosf_address(uint16_t port, uint16_t reg)
return (void *)addr;
}
-inline static void iosf_write(uint16_t port, uint16_t reg, uint32_t val)
+static inline void iosf_write(uint16_t port, uint16_t reg, uint32_t val)
{
write32(iosf_address(port, reg), val);
}
-inline static uint32_t iosf_read(uint16_t port, uint16_t reg)
+static inline uint32_t iosf_read(uint16_t port, uint16_t reg)
{
return read32(iosf_address(port, reg));
}
More information about the coreboot-gerrit
mailing list