[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: Fix parenthesis issues

[Lee Leahy (leroy.p.leahy@intel.com)]

Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18725

-gerrit

commit 3198eb2faa2667a425b0f18317414e01f6d82e02
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Thu Mar 9 10:10:25 2017 -0800

    soc/intel/apollolake: Fix parenthesis issues
    
    Fix the following errors and warning detected by checkpatch.pl:
    
    ERROR: space required before the open parenthesis '('
    ERROR: space prohibited before that close parenthesis ')'
    ERROR: return is not a function, parentheses are not required
    WARNING: space prohibited between function name and open parenthesis '('
    
    TEST=Build for reef
    
    Change-Id: I31f854adf3269ba6f77c4044fb3748bb1957841c
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/apollolake/acpi.c       | 4 ++--
 src/soc/intel/apollolake/car.c        | 2 +-
 src/soc/intel/apollolake/elog.c       | 2 +-
 src/soc/intel/apollolake/gpio.c       | 4 ++--
 src/soc/intel/apollolake/reset.c      | 2 +-
 src/soc/intel/apollolake/uart_early.c | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 8853678..380ed7e 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -283,7 +283,7 @@ static void acpigen_soc_get_dw0_in_local5(uintptr_t addr)
 
 static int acpigen_soc_get_gpio_val(unsigned int gpio_num, uint32_t mask)
 {
-	assert (gpio_num < TOTAL_PADS);
+	assert(gpio_num < TOTAL_PADS);
 	uintptr_t addr = (uintptr_t)gpio_dwx_address(gpio_num);
 
 	acpigen_soc_get_dw0_in_local5(addr);
@@ -309,7 +309,7 @@ static int acpigen_soc_get_gpio_val(unsigned int gpio_num, uint32_t mask)
 
 static int acpigen_soc_set_gpio_val(unsigned int gpio_num, uint32_t val)
 {
-	assert (gpio_num < TOTAL_PADS);
+	assert(gpio_num < TOTAL_PADS);
 	uintptr_t addr = (uintptr_t)gpio_dwx_address(gpio_num);
 
 	acpigen_soc_get_dw0_in_local5(addr);
diff --git a/src/soc/intel/apollolake/car.c b/src/soc/intel/apollolake/car.c
index d58dc0a..2d2f7a0 100644
--- a/src/soc/intel/apollolake/car.c
+++ b/src/soc/intel/apollolake/car.c
@@ -52,7 +52,7 @@ void platform_segment_loaded(uintptr_t start, size_t size, int flags)
 		return;
 
 	/* Loaded program segment should lie entirely within CAR region. */
-	assert (start_car_check && end_car_check);
+	assert(start_car_check && end_car_check);
 
 	flush_l1d_to_l2();
 }
diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c
index 4c4f197..f061188 100644
--- a/src/soc/intel/apollolake/elog.c
+++ b/src/soc/intel/apollolake/elog.c
@@ -49,7 +49,7 @@ static void pch_log_wake_source(struct chipset_power_state *ps)
 		elog_add_event_wake(ELOG_WAKE_SOURCE_PCIE, 0);
 
 	/* PME */
-	if(ps->gpe0_sts[GPE0_A] & CSE_PME_STS)
+	if (ps->gpe0_sts[GPE0_A] & CSE_PME_STS)
 		elog_add_event_wake(ELOG_WAKE_SOURCE_PME, 0);
 
 	/* SMBUS Wake */
diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c
index 95e2294..affba3d 100644
--- a/src/soc/intel/apollolake/gpio.c
+++ b/src/soc/intel/apollolake/gpio.c
@@ -143,7 +143,7 @@ static void gpi_enable_smi(const struct pad_config *cfg, uint16_t port, int pin)
 
 	/* Set enable bits */
 	en_reg = GPI_SMI_EN_OFFSET(group);
-	value = iosf_read(port, en_reg );
+	value = iosf_read(port, en_reg);
 	value |= 1 << (pin % GPIO_MAX_NUM_PER_GROUP);
 	iosf_write(port, en_reg, value);
 }
@@ -348,7 +348,7 @@ int gpi_status_get(const struct gpi_status *sts, gpio_t gpi)
 /* Helper function to map PMC register groups to tier1 sci groups */
 static int pmc_gpe_route_to_gpio(int route)
 {
-	switch(route) {
+	switch (route) {
 	case PMC_GPE_SW_31_0:
 		return GPIO_GPE_SW_31_0;
 	case PMC_GPE_SW_63_32:
diff --git a/src/soc/intel/apollolake/reset.c b/src/soc/intel/apollolake/reset.c
index 3e62d81..56273cc 100644
--- a/src/soc/intel/apollolake/reset.c
+++ b/src/soc/intel/apollolake/reset.c
@@ -61,7 +61,7 @@ void reset_prepare(void)
 
 void chipset_handle_reset(uint32_t status)
 {
-	switch(status) {
+	switch (status) {
 	case FSP_STATUS_RESET_REQUIRED_5: /* Global Reset */
 		global_reset();
 		break;
diff --git a/src/soc/intel/apollolake/uart_early.c b/src/soc/intel/apollolake/uart_early.c
index 0e53060..173e8a1 100644
--- a/src/soc/intel/apollolake/uart_early.c
+++ b/src/soc/intel/apollolake/uart_early.c
@@ -65,7 +65,7 @@ void lpss_console_uart_init(void)
 
 uintptr_t uart_platform_base(int idx)
 {
-	return (CONFIG_CONSOLE_UART_BASE_ADDRESS);
+	return CONFIG_CONSOLE_UART_BASE_ADDRESS;
 }
 
 static const struct pad_config uart_gpios[] = {