[coreboot-gerrit] Patch merged into coreboot/master: intel/skylake: Filter suspend well power failure event for Deep Sx

gerrit at coreboot.org gerrit at coreboot.org
Wed Mar 8 19:08:13 CET 2017


the following patch was just integrated into master:
commit ac2cbd0ffbcf4950c899ea8336fd6fbb8833569b
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Mar 7 19:22:24 2017 -0800

    intel/skylake: Filter suspend well power failure event for Deep Sx
    
    If Deep Sx is enabled the event log will get entries added on every
    power sequence transition indicating that the suspend well has failed.
    
    When a board is using Deep Sx by design this is intended behavior and
    just fills the logs with extraneous events.
    
    To make this work the device init state has to be executed first so it
    actually enables the Deep Sx policies in the SOC since this code does
    not have any hooks back into the devicetree to read the intended setting
    from there.
    
    BUG=b:36042662
    BRANCH=none
    TEST=Perform suspend/resume on Eve device with Deep S3 enabled, and
    then check the event log to be sure that it does not contain the
    "SUS Power Fail" event.
    
    Change-Id: I3c8242baa63685232025e1dfef5595ec0ec6d14a
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://review.coreboot.org/18664
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/18664 for details.

-gerrit



More information about the coreboot-gerrit mailing list