[coreboot-gerrit] Patch merged into coreboot/master: binaryPI platforms: Drop any ACPI S3 support

gerrit at coreboot.org gerrit at coreboot.org
Wed Mar 8 04:08:33 CET 2017


the following patch was just integrated into master:
commit 97a4b3edf0efbbc051ec604ccdd7cf6d86c67187
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sun Feb 26 10:18:45 2017 +0200

    binaryPI platforms: Drop any ACPI S3 support
    
    No board with binaryPI currently supports HAVE_ACPI_RESUME. For
    platforms with PSP the approach is also very different from what
    we previously had here.
    
    Furthermore, s3_resume.[ch] files under cpu/amd/pi do not
    distinguish between NonVolatile and Volatile buffers of S3 storage.
    This means the Volatile buffer that is maintained and available in
    CBMEM is unnecessarily copied to SPI flash. This has been fixed on
    open-source AGESA directory, so development of S3 suspend support
    with binaryPI is better continued with that.
    
    Unfortunately there are further complications and indications that
    open-source AGESA may have always had a low-memory corruption
    issue. This has to be investigated separately before restoring
    or claiming S3 is supported on binaryPI.
    
    Change-Id: I81585fff7aae7bcdd55e5e95bc373e0adef43ef0
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-on: https://review.coreboot.org/18501
    Tested-by: build bot (Jenkins)
    Reviewed-by: Marc Jones <marc at marcjonesconsulting.com>


See https://review.coreboot.org/18501 for details.

-gerrit



More information about the coreboot-gerrit mailing list