[coreboot-gerrit] Patch merged into coreboot/master: util/docker: Update dockerfiles & build method

gerrit at coreboot.org gerrit at coreboot.org
Mon Mar 6 00:30:39 CET 2017


the following patch was just integrated into master:
commit 561f368a2f2bb9042878e40b1f34bf605b956a33
Author: Martin Roth <gaumless at gmail.com>
Date:   Fri Dec 30 17:00:19 2016 -0700

    util/docker: Update dockerfiles & build method
    
    All files:
    - Previously, various things were hardcoded into the docker containers
    that made it necessary to update the Dockerfile files for each new
    version of the sdk.  Turn those into 'Variables" that are updated during
    the build step.  Because the makefile is piping the dockerfile through
    the sed command and back into the docker build command, the normal
    docker "COPY" keyword doesn't work.
    
    coreboot-jenkins-node changes:
    - Run ssh-keygen -A to explicitly generate the ssh keys.  This fixes an
    error:  Could not load host key: /etc/ssh/ssh_host_dsa_key
    
    coreboot-sdk changes:
    - Remove apt-get upgrade command - The Dockerfile guide recommends
    not to run this.
    - Change libssl-dev to libssl1.0-dev. libssl-dev's header files won't
    build the Chrome-EC codebase.
    - Add libisl-dev, needed to build the riscv toolchain.
    - Build the toolchain using the -b option
    - Add environment variables containing the version and commit that the
    coreboot-sdk was built from.
    
    Makefile:
    - Update targets to use the version and commit variables
    
    Change-Id: I2c1376fe4b791da2a62fca11bc92c4774cbef1c8
    Signed-off-by: Martin Roth <gaumless at gmail.com>
    Reviewed-on: https://review.coreboot.org/18001
    Tested-by: build bot (Jenkins)
    Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>


See https://review.coreboot.org/18001 for details.

-gerrit



More information about the coreboot-gerrit mailing list