[coreboot-gerrit] New patch to review for coreboot: elog: Fix duplicate event type

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Mon Mar 6 00:14:06 CET 2017


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18579

-gerrit

commit e8a581898c5517b09551eb0b8e4f02e045a9f4c5
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Sun Mar 5 14:35:57 2017 -0800

    elog: Fix duplicate event type
    
    The current elog implementation has two event types defined for 0xa7,
    apparently the result of divergent coreboot trees on chromium where
    some events were added to ARM systems but not upstreamed until later.
    
    Fix this by moving ELOG_TYPE_THERM_TRIP to be 0xab, since the current
    elog parsing code in chromium is using ELOG_TYPE_SLEEP for 0xa7.
    
    BUG=b:35977516
    TEST=check for proper "CPU Thermal Trip" event when investigating a
    device that is unexpectedly powering down.
    
    Change-Id: Idfa9b2322527803097f4f19f7930ccbdf2eccf35
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/include/elog.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/include/elog.h b/src/include/elog.h
index 501e30d..2734612 100644
--- a/src/include/elog.h
+++ b/src/include/elog.h
@@ -146,9 +146,6 @@ struct elog_event_data_me_extended {
 /* EC Shutdown Reason */
 #define ELOG_TYPE_EC_SHUTDOWN             0xa5
 
-/* CPU Thermal Trip */
-#define ELOG_TYPE_THERM_TRIP              0xa7
-
 /* ARM/generic versions of sleep/wake - These came from another firmware
  * apparently, but not all the firmware sources were updated so that the
  * elog namespace was coherent. */
@@ -168,6 +165,9 @@ struct elog_event_mem_cache_update {
 	u8 status;
 } __attribute__ ((packed));
 
+/* CPU Thermal Trip */
+#define ELOG_TYPE_THERM_TRIP              0xab
+
 #if CONFIG_ELOG
 /* Eventlog backing storage must be initialized before calling elog_init(). */
 extern int elog_init(void);



More information about the coreboot-gerrit mailing list