[coreboot-gerrit] Change in coreboot[master]: soc/intel/quark/spi.c: Remove unused status assignment

[Martin Kepplinger (Code Review)]

Martin Kepplinger has uploaded this change for review. ( https://review.coreboot.org/20411


Change subject: soc/intel/quark/spi.c: Remove unused status assignment
......................................................................

soc/intel/quark/spi.c: Remove unused status assignment

This removes an unused assignment of the local status variable and thus
improves readability. Coverity had found this:

*** CID 1376473:  Code maintainability issues  (UNUSED_VALUE)
/src/soc/intel/quark/spi.c: 169 in xfer()
163     		}
164
165     		/* Use chip select 0 */
166     		ctrlr->address = (data[0] << 16)
167     			       | (data[1] << 8)
168     			       |  data[2];

CID 1376473:  Code maintainability issues  (UNUSED_VALUE)
Assigning value from "ctrlr->address" to "status" here, but that stored value
is overwritten before it can be used.

169     		status = ctrlr->address;
170     		data += 3;
171     		bytesout -= 3;
172     	}
173
174     	/* Build the control value */

Change-Id: I0a364539c37005cfd637b75c8cc23b84e274294d
Signed-off-by: Martin Kepplinger <martink at posteo.de>
---
M src/soc/intel/quark/spi.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/20411/1

diff --git a/src/soc/intel/quark/spi.c b/src/soc/intel/quark/spi.c
index 1d257a5..68f445f 100644
--- a/src/soc/intel/quark/spi.c
+++ b/src/soc/intel/quark/spi.c
@@ -166,7 +166,6 @@
 		ctrlr->address = (data[0] << 16)
 			       | (data[1] << 8)
 			       |  data[2];
-		status = ctrlr->address;
 		data += 3;
 		bytesout -= 3;
 	}

-- 
To view, visit https://review.coreboot.org/20411
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a364539c37005cfd637b75c8cc23b84e274294d
Gerrit-Change-Number: 20411
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Kepplinger <martink at posteo.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170629/4cc3fdaa/attachment.html>