[coreboot-gerrit] Change in coreboot[master]: northbridge/intel: Add whitespace around '<<'

[Philippe Mathieu-Daudé (Code Review)]

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20398 )

Change subject: northbridge/intel: Add whitespace around '<<'
......................................................................


Patch Set 5:

(7 comments)

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/e7505/raminit.c
File src/northbridge/intel/e7505/raminit.c:

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/e7505/raminit.c@1849
PS5, Line 1849: |
can you add spaces around | while here?


https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/i945/raminit.c@251
PS5, Line 251: |
spaces


https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/pineview/raminit.c
File src/northbridge/intel/pineview/raminit.c:

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/pineview/raminit.c@74
PS5, Line 74: #define CHANNEL_IS_POPULATED(dimms, idx) ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0))
            : #define CHANNEL_IS_CARDF(dimms, idx) ((dimms[idx << 1].card_type == 0xf) || (dimms[(idx << 1) + 1].card_type == 0xf))
            : #define IF_CHANNEL_POPULATED(dimms, idx) if ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0))
break at 80


https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/sandybridge/raminit_common.h
File src/northbridge/intel/sandybridge/raminit_common.h:

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/sandybridge/raminit_common.h@148
PS5, Line 148: |
spaces


https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/raminit_ddr2.c
File src/northbridge/intel/x4x/raminit_ddr2.c:

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/raminit_ddr2.c@1620
PS5, Line 1620: (r)
remove parentheses


https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h
File src/northbridge/intel/x4x/x4x.h:

https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h@184
PS5, Line 184: 	((dimms[(ch << 1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch << 1) + 1].ranks + 2))))
break at 80


https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h@189
PS5, Line 189: (r)
remove ()



-- 
To view, visit https://review.coreboot.org/20398
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf2653c08c4955bf95dcbec2d5a0c891339866b
Gerrit-Change-Number: 20398
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug at amsat.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 29 Jun 2017 03:52:05 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170629/d65440b0/attachment.html>