<p>Philippe Mathieu-Daudé <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20398">View Change</a></p><p>Patch set 5:</p><p>(7 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/e7505/raminit.c">File src/northbridge/intel/e7505/raminit.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/e7505/raminit.c@1849">Patch Set #5, Line 1849:</a> <code style="font-family:monospace,monospace">|</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">can you add spaces around | while here?</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/i945/raminit.c">File src/northbridge/intel/i945/raminit.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/i945/raminit.c@251">Patch Set #5, Line 251:</a> <code style="font-family:monospace,monospace">|</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/pineview/raminit.c">File src/northbridge/intel/pineview/raminit.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/pineview/raminit.c@74">Patch Set #5, Line 74:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#define CHANNEL_IS_POPULATED(dimms, idx) ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0))<br>#define CHANNEL_IS_CARDF(dimms, idx) ((dimms[idx << 1].card_type == 0xf) || (dimms[(idx << 1) + 1].card_type == 0xf))<br>#define IF_CHANNEL_POPULATED(dimms, idx) if ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0))<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">break at 80</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/sandybridge/raminit_common.h">File src/northbridge/intel/sandybridge/raminit_common.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/sandybridge/raminit_common.h@148">Patch Set #5, Line 148:</a> <code style="font-family:monospace,monospace">|</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/raminit_ddr2.c">File src/northbridge/intel/x4x/raminit_ddr2.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/raminit_ddr2.c@1620">Patch Set #5, Line 1620:</a> <code style="font-family:monospace,monospace">(r)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove parentheses</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h">File src/northbridge/intel/x4x/x4x.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h@184">Patch Set #5, Line 184:</a> <code style="font-family:monospace,monospace"> ((dimms[(ch << 1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch << 1) + 1].ranks + 2))))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">break at 80</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h@189">Patch Set #5, Line 189:</a> <code style="font-family:monospace,monospace">(r)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove ()</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20398">change 20398</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20398"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0bf2653c08c4955bf95dcbec2d5a0c891339866b </div>
<div style="display:none"> Gerrit-Change-Number: 20398 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug@amsat.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Jun 2017 03:52:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>