[coreboot-gerrit] Change in coreboot[master]: drv/intel/gma/acpi/common: Remove dead code
Patrick Rudolph (Code Review)
gerrit at coreboot.org
Mon Jun 26 18:24:40 CEST 2017
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20369
Change subject: drv/intel/gma/acpi/common: Remove dead code
......................................................................
drv/intel/gma/acpi/common: Remove dead code
The TRAP mechanism is broken ever since, and the only board that had a
working TRAP handler that checks for function one is Lenovo T60/X60.
It's not clear if this is required or just a copy&paste error.
As all other boards do work fine without that TRAP handler installed,
assume it can safely be removed.
Change-Id: I3867ccad564c9d1da04823afdd82a8dd57d042ff
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/drivers/intel/gma/acpi/common.asl
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/20369/1
diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl
index dd294fe..ae681f6 100644
--- a/src/drivers/intel/gma/acpi/common.asl
+++ b/src/drivers/intel/gma/acpi/common.asl
@@ -80,7 +80,6 @@
/* Device Current Status */
Method(XDCS, 1)
{
- TRAP(1)
If (And(CSTE, ShiftLeft (1, Arg0))) {
Return (0x1f)
}
--
To view, visit https://review.coreboot.org/20369
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3867ccad564c9d1da04823afdd82a8dd57d042ff
Gerrit-Change-Number: 20369
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170626/9ed146fe/attachment-0001.html>
More information about the coreboot-gerrit
mailing list