<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20369">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drv/intel/gma/acpi/common: Remove dead code<br><br>The TRAP mechanism is broken ever since, and the only board that had a<br>working TRAP handler that checks for function one is Lenovo T60/X60.<br>It's not clear if this is required or just a copy&paste error.<br>As all other boards do work fine without that TRAP handler installed,<br>assume it can safely be removed.<br><br>Change-Id: I3867ccad564c9d1da04823afdd82a8dd57d042ff<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/drivers/intel/gma/acpi/common.asl<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/20369/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl<br>index dd294fe..ae681f6 100644<br>--- a/src/drivers/intel/gma/acpi/common.asl<br>+++ b/src/drivers/intel/gma/acpi/common.asl<br>@@ -80,7 +80,6 @@<br>    /* Device Current Status */<br>   Method(XDCS, 1)<br>       {<br>-            TRAP(1)<br>               If (And(CSTE, ShiftLeft (1, Arg0))) {<br>                         Return (0x1f)<br>                 }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20369">change 20369</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20369"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3867ccad564c9d1da04823afdd82a8dd57d042ff </div>
<div style="display:none"> Gerrit-Change-Number: 20369 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>