[coreboot-gerrit] Change in coreboot[master]: mb/*/romstage, sb/intel/ibexpeak/lpc: Remove custom ACPI TRAP...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20329


Change subject: mb/*/romstage,sb/intel/ibexpeak/lpc: Remove custom ACPI TRAP configuration
......................................................................

mb/*/romstage,sb/intel/ibexpeak/lpc: Remove custom ACPI TRAP configuration

Get rid of custom ACPI TRAP code.
The previos commit introduced mainboard independed ACPI TRAP handling.

Change-Id: I83fa97fab153e2709e1ef20e014b91c3410d4c5b
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/mainboard/apple/macbook21/romstage.c
M src/mainboard/getac/p470/romstage.c
M src/mainboard/lenovo/t400/romstage.c
M src/mainboard/lenovo/t60/romstage.c
M src/mainboard/lenovo/x200/romstage.c
M src/mainboard/lenovo/x60/romstage.c
M src/mainboard/roda/rk886ex/romstage.c
M src/southbridge/intel/ibexpeak/lpc.c
8 files changed, 0 insertions(+), 30 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/20329/1

diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c
index 92dfe74..581c556 100644
--- a/src/mainboard/apple/macbook21/romstage.c
+++ b/src/mainboard/apple/macbook21/romstage.c
@@ -180,12 +180,6 @@
 	/* Disable unused devices */
 	RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_PCIE4 | FD_PCIE3 | FD_INTLAN | FD_ACMOD | FD_ACAUD;
 	RCBA32(0x3418) |= (1 << 0);	/* Required. */
-
-	/* Set up I/O Trap #0 for 0xfe00 (SMIC) */
-
-	/* Set up I/O Trap #3 for 0x800-0x80c (Trap) */
-	RCBA32(0x1e9c) = 0x000200f0;
-	RCBA32(0x1e98) = 0x000c0801;
 }
 
 static void early_ich7_init(void)
diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c
index d1552a6..bbd05f8 100644
--- a/src/mainboard/getac/p470/romstage.c
+++ b/src/mainboard/getac/p470/romstage.c
@@ -176,10 +176,6 @@
 	/* Set up I/O Trap #0 for 0xfe00 (SMIC) */
 	RCBA32(0x1e84) = 0x00020001;
 	RCBA32(0x1e80) = 0x0000fe01;
-
-	/* Set up I/O Trap #3 for 0x800-0x80c (Trap) */
-	RCBA32(0x1e9c) = 0x000200f0;
-	RCBA32(0x1e98) = 0x000c0801;
 }
 
 static void early_ich7_init(void)
diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c
index 1a5c17c..287fee0 100644
--- a/src/mainboard/lenovo/t400/romstage.c
+++ b/src/mainboard/lenovo/t400/romstage.c
@@ -148,8 +148,6 @@
 	RCBA32(0x0288) = 0x00600b4e;
 	RCBA32(0x1e10) = 0x00020800;
 	RCBA32(0x1e18) = 0x36ea00a0;
-	RCBA32(0x1e80) = 0x000c0801;
-	RCBA32(0x1e84) = 0x000200f0;
 	RCBA32(0x2028) = 0x04c8f95e;
 	RCBA32(0x202c) = 0x055c095e;
 	RCBA32(0x204c) = 0x001ffc00;
diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c
index 80b989f..15a0c0a 100644
--- a/src/mainboard/lenovo/t60/romstage.c
+++ b/src/mainboard/lenovo/t60/romstage.c
@@ -108,10 +108,6 @@
 	/* Set up I/O Trap #0 for 0xfe00 (SMIC) */
 	RCBA32(0x1e84) = 0x00020001;
 	RCBA32(0x1e80) = 0x0000fe01;
-
-	/* Set up I/O Trap #3 for 0x800-0x80c (Trap) */
-	RCBA32(0x1e9c) = 0x000200f0;
-	RCBA32(0x1e98) = 0x000c0801;
 }
 
 static void early_ich7_init(void)
diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c
index 02f7116..e4d2ae7 100644
--- a/src/mainboard/lenovo/x200/romstage.c
+++ b/src/mainboard/lenovo/x200/romstage.c
@@ -139,8 +139,6 @@
 	RCBA32(0x0288) = 0x00600b4e;
 	RCBA32(0x1e10) = 0x00020800;
 	RCBA32(0x1e18) = 0x36ea00a0;
-	RCBA32(0x1e80) = 0x000c0801;
-	RCBA32(0x1e84) = 0x000200f0;
 	RCBA32(0x2028) = 0x04c8f95e;
 	RCBA32(0x202c) = 0x055c095e;
 	RCBA32(0x204c) = 0x001ffc00;
diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c
index eddb150..aff6c7c 100644
--- a/src/mainboard/lenovo/x60/romstage.c
+++ b/src/mainboard/lenovo/x60/romstage.c
@@ -108,10 +108,6 @@
 	/* Set up I/O Trap #0 for 0xfe00 (SMIC) */
 	RCBA32(0x1e84) = 0x00020001;
 	RCBA32(0x1e80) = 0x0000fe01;
-
-	/* Set up I/O Trap #3 for 0x800-0x80c (Trap) */
-	RCBA32(0x1e9c) = 0x000200f0;
-	RCBA32(0x1e98) = 0x000c0801;
 }
 
 static void early_ich7_init(void)
diff --git a/src/mainboard/roda/rk886ex/romstage.c b/src/mainboard/roda/rk886ex/romstage.c
index a488488..e93340c 100644
--- a/src/mainboard/roda/rk886ex/romstage.c
+++ b/src/mainboard/roda/rk886ex/romstage.c
@@ -145,10 +145,6 @@
 	/* Set up I/O Trap #0 for 0xfe00 (SMIC) */
 	RCBA32(0x1e84) = 0x00020001;
 	RCBA32(0x1e80) = 0x0000fe01;
-
-	/* Set up I/O Trap #3 for 0x800-0x80c (Trap) */
-	RCBA32(0x1e9c) = 0x000200f0;
-	RCBA32(0x1e98) = 0x000c0801;
 }
 
 static void early_ich7_init(void)
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c
index f01d8b2..604979c 100644
--- a/src/southbridge/intel/ibexpeak/lpc.c
+++ b/src/southbridge/intel/ibexpeak/lpc.c
@@ -300,10 +300,6 @@
 	(void) RCBA32 (0x1d44);
 	RCBA32 (0x1d48) = 0x00030000;
 	(void) RCBA32 (0x1d48);
-	RCBA32 (0x1e80) = 0x000c0801;
-	(void) RCBA32 (0x1e80);
-	RCBA32 (0x1e84) = 0x000200f0;
-	(void) RCBA32 (0x1e84);
 
 	const u32 rcba2010[] =
 		{

-- 
To view, visit https://review.coreboot.org/20329
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83fa97fab153e2709e1ef20e014b91c3410d4c5b
Gerrit-Change-Number: 20329
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170625/b6ad2ec7/attachment.html>