<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20329">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/*/romstage,sb/intel/ibexpeak/lpc: Remove custom ACPI TRAP configuration<br><br>Get rid of custom ACPI TRAP code.<br>The previos commit introduced mainboard independed ACPI TRAP handling.<br><br>Change-Id: I83fa97fab153e2709e1ef20e014b91c3410d4c5b<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/mainboard/apple/macbook21/romstage.c<br>M src/mainboard/getac/p470/romstage.c<br>M src/mainboard/lenovo/t400/romstage.c<br>M src/mainboard/lenovo/t60/romstage.c<br>M src/mainboard/lenovo/x200/romstage.c<br>M src/mainboard/lenovo/x60/romstage.c<br>M src/mainboard/roda/rk886ex/romstage.c<br>M src/southbridge/intel/ibexpeak/lpc.c<br>8 files changed, 0 insertions(+), 30 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/20329/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c<br>index 92dfe74..581c556 100644<br>--- a/src/mainboard/apple/macbook21/romstage.c<br>+++ b/src/mainboard/apple/macbook21/romstage.c<br>@@ -180,12 +180,6 @@<br>      /* Disable unused devices */<br>  RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_PCIE4 | FD_PCIE3 | FD_INTLAN | FD_ACMOD | FD_ACAUD;<br>         RCBA32(0x3418) |= (1 << 0);       /* Required. */<br>-<br>-   /* Set up I/O Trap #0 for 0xfe00 (SMIC) */<br>-<br>-        /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */<br>-      RCBA32(0x1e9c) = 0x000200f0;<br>- RCBA32(0x1e98) = 0x000c0801;<br> }<br> <br> static void early_ich7_init(void)<br>diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c<br>index d1552a6..bbd05f8 100644<br>--- a/src/mainboard/getac/p470/romstage.c<br>+++ b/src/mainboard/getac/p470/romstage.c<br>@@ -176,10 +176,6 @@<br>    /* Set up I/O Trap #0 for 0xfe00 (SMIC) */<br>    RCBA32(0x1e84) = 0x00020001;<br>  RCBA32(0x1e80) = 0x0000fe01;<br>-<br>-      /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */<br>-      RCBA32(0x1e9c) = 0x000200f0;<br>- RCBA32(0x1e98) = 0x000c0801;<br> }<br> <br> static void early_ich7_init(void)<br>diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c<br>index 1a5c17c..287fee0 100644<br>--- a/src/mainboard/lenovo/t400/romstage.c<br>+++ b/src/mainboard/lenovo/t400/romstage.c<br>@@ -148,8 +148,6 @@<br>         RCBA32(0x0288) = 0x00600b4e;<br>  RCBA32(0x1e10) = 0x00020800;<br>  RCBA32(0x1e18) = 0x36ea00a0;<br>- RCBA32(0x1e80) = 0x000c0801;<br>- RCBA32(0x1e84) = 0x000200f0;<br>  RCBA32(0x2028) = 0x04c8f95e;<br>  RCBA32(0x202c) = 0x055c095e;<br>  RCBA32(0x204c) = 0x001ffc00;<br>diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c<br>index 80b989f..15a0c0a 100644<br>--- a/src/mainboard/lenovo/t60/romstage.c<br>+++ b/src/mainboard/lenovo/t60/romstage.c<br>@@ -108,10 +108,6 @@<br>       /* Set up I/O Trap #0 for 0xfe00 (SMIC) */<br>    RCBA32(0x1e84) = 0x00020001;<br>  RCBA32(0x1e80) = 0x0000fe01;<br>-<br>-      /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */<br>-      RCBA32(0x1e9c) = 0x000200f0;<br>- RCBA32(0x1e98) = 0x000c0801;<br> }<br> <br> static void early_ich7_init(void)<br>diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c<br>index 02f7116..e4d2ae7 100644<br>--- a/src/mainboard/lenovo/x200/romstage.c<br>+++ b/src/mainboard/lenovo/x200/romstage.c<br>@@ -139,8 +139,6 @@<br>         RCBA32(0x0288) = 0x00600b4e;<br>  RCBA32(0x1e10) = 0x00020800;<br>  RCBA32(0x1e18) = 0x36ea00a0;<br>- RCBA32(0x1e80) = 0x000c0801;<br>- RCBA32(0x1e84) = 0x000200f0;<br>  RCBA32(0x2028) = 0x04c8f95e;<br>  RCBA32(0x202c) = 0x055c095e;<br>  RCBA32(0x204c) = 0x001ffc00;<br>diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c<br>index eddb150..aff6c7c 100644<br>--- a/src/mainboard/lenovo/x60/romstage.c<br>+++ b/src/mainboard/lenovo/x60/romstage.c<br>@@ -108,10 +108,6 @@<br>       /* Set up I/O Trap #0 for 0xfe00 (SMIC) */<br>    RCBA32(0x1e84) = 0x00020001;<br>  RCBA32(0x1e80) = 0x0000fe01;<br>-<br>-      /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */<br>-      RCBA32(0x1e9c) = 0x000200f0;<br>- RCBA32(0x1e98) = 0x000c0801;<br> }<br> <br> static void early_ich7_init(void)<br>diff --git a/src/mainboard/roda/rk886ex/romstage.c b/src/mainboard/roda/rk886ex/romstage.c<br>index a488488..e93340c 100644<br>--- a/src/mainboard/roda/rk886ex/romstage.c<br>+++ b/src/mainboard/roda/rk886ex/romstage.c<br>@@ -145,10 +145,6 @@<br>    /* Set up I/O Trap #0 for 0xfe00 (SMIC) */<br>    RCBA32(0x1e84) = 0x00020001;<br>  RCBA32(0x1e80) = 0x0000fe01;<br>-<br>-      /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */<br>-      RCBA32(0x1e9c) = 0x000200f0;<br>- RCBA32(0x1e98) = 0x000c0801;<br> }<br> <br> static void early_ich7_init(void)<br>diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c<br>index f01d8b2..604979c 100644<br>--- a/src/southbridge/intel/ibexpeak/lpc.c<br>+++ b/src/southbridge/intel/ibexpeak/lpc.c<br>@@ -300,10 +300,6 @@<br>        (void) RCBA32 (0x1d44);<br>       RCBA32 (0x1d48) = 0x00030000;<br>         (void) RCBA32 (0x1d48);<br>-      RCBA32 (0x1e80) = 0x000c0801;<br>-        (void) RCBA32 (0x1e80);<br>-      RCBA32 (0x1e84) = 0x000200f0;<br>-        (void) RCBA32 (0x1e84);<br> <br>    const u32 rcba2010[] =<br>                {<br></pre><p>To view, visit <a href="https://review.coreboot.org/20329">change 20329</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20329"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I83fa97fab153e2709e1ef20e014b91c3410d4c5b </div>
<div style="display:none"> Gerrit-Change-Number: 20329 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>