[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: Do not reset PMIC during sleep
Naresh Solanki (Code Review)
gerrit at coreboot.org
Tue Jun 20 11:21:47 CEST 2017
Hello Divagar Mohandass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/20264
to look at the new patch set (#2).
Change subject: mb/google/soraka: Do not reset PMIC during sleep
......................................................................
mb/google/soraka: Do not reset PMIC during sleep
Due to reset, PMIC looses its internal register state. This causes PMIC
to be in improper state after sleep.
To avoid the same, do not reset PMIC while entering sleep.
TEST= Build the firmware for Soraka & Boot to OS. Do S3 resume & check
whether PMIC internal register state is preserved.
Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582
Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
---
M src/mainboard/google/poppy/smihandler.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/20264/2
--
To view, visit https://review.coreboot.org/20264
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582
Gerrit-Change-Number: 20264
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass at intel.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170620/85fbacc4/attachment.html>
More information about the coreboot-gerrit
mailing list