[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: Do not reset PMIC during sleep

Naresh Solanki (Code Review) gerrit at coreboot.org
Tue Jun 20 11:12:28 CEST 2017


Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/20264


Change subject: mb/google/soraka: Do not reset PMIC during sleep
......................................................................

mb/google/soraka: Do not reset PMIC during sleep

Due to reset, PMIC looses its internal register state. This causes PMIC
to be in improper state after sleep.

To avoid the same, do not reset PMIC while entering sleep.

TEST= Build the firmware for Soraka & Boot to OS. Do S3 resume & check
whether PMIC internal register state is preserved.

Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582
Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
---
M src/mainboard/google/poppy/smihandler.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/20264/1

diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c
index 30b009d..bcaa2e4 100644
--- a/src/mainboard/google/poppy/smihandler.c
+++ b/src/mainboard/google/poppy/smihandler.c
@@ -30,7 +30,6 @@
 static void mainboard_gpio_smi_sleep(void)
 {
 	/* Hold camera device in reset and then power it down. */
-	gpio_set(EN_CAM_PMIC_RST_L, 0);
 	gpio_set(EN_PP3300_DX_CAM, 0);
 }
 

-- 
To view, visit https://review.coreboot.org/20264
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582
Gerrit-Change-Number: 20264
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170620/f329138e/attachment.html>


More information about the coreboot-gerrit mailing list