[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Fix dual DIMM command rate

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20270 )

Change subject: nb/intel/sandybridge/raminit: Fix dual DIMM command rate
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/20270/1/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/20270/1/src/northbridge/intel/sandybridge/raminit_common.c@2358
PS1, Line 2358: 		if ((ctrl->rankmap[channel] & 0x5) == 0x5) {
              : 			err = try_cmd_stretch(ctrl, channel, 2);
              : 			if (err) {
              : 				printk(BIOS_EMERG, "c320c discovery failed\n");
              : 				return err;
              : 			}
              : 
              : 			continue;
              : 		}
              : 
              : 		/*
              : 		 * Single DIMM per channel:
              : 		 * Try command rate 1T and 2T
              : 		 */
              : 		err = try_cmd_stretch(ctrl, channel, 0);
              : 		if (err) {
              : 			err = try_cmd_stretch(ctrl, channel, 2);
              : 			if (err) {
              : 				printk(BIOS_EMERG, "c320c discovery failed\n");
              : 				return err;
              : 			}
              : 			printram("Using CMD rate 2T on channel %u\n", channel);
              : 		} else
              : 			printram("Using CMD rate 1T on channel %u\n", channel);
the code could be a bit prettier if attempted CMD rate is made a a variable.



-- 
To view, visit https://review.coreboot.org/20270
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I029d01092fd0e11390cebcd94ca6f23bf0ee2cab
Gerrit-Change-Number: 20270
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 20 Jun 2017 07:19:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170620/47f3ae3a/attachment.html>