<p>Arthur Heymans <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20270">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20270/1/src/northbridge/intel/sandybridge/raminit_common.c">File src/northbridge/intel/sandybridge/raminit_common.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20270/1/src/northbridge/intel/sandybridge/raminit_common.c@2358">Patch Set #1, Line 2358:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">             if ((ctrl->rankmap[channel] & 0x5) == 0x5) {<br>                   err = try_cmd_stretch(ctrl, channel, 2);<br>                      if (err) {<br>                            printk(BIOS_EMERG, "c320c discovery failed\n");<br>                             return err;<br>                   }<br><br>                   continue;<br>             }<br><br>           /*<br>             * Single DIMM per channel:<br>            * Try command rate 1T and 2T<br>          */<br>           err = try_cmd_stretch(ctrl, channel, 0);<br>              if (err) {<br>                    err = try_cmd_stretch(ctrl, channel, 2);<br>                      if (err) {<br>                            printk(BIOS_EMERG, "c320c discovery failed\n");<br>                             return err;<br>                   }<br>                     printram("Using CMD rate 2T on channel %u\n", channel);<br>             } else<br>                        printram("Using CMD rate 1T on channel %u\n", channel);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">the code could be a bit prettier if attempted CMD rate is made a a variable.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20270">change 20270</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20270"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I029d01092fd0e11390cebcd94ca6f23bf0ee2cab </div>
<div style="display:none"> Gerrit-Change-Number: 20270 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 20 Jun 2017 07:19:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>