[coreboot-gerrit] Change in coreboot[master]: google/parrot: make chromeos.c compilation conditional on CO...

Martin Roth (Code Review) gerrit at coreboot.org
Sun Jun 4 18:41:49 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19959 )

Change subject: google/parrot: make chromeos.c compilation conditional on CONFIG_CHROMEOS
......................................................................

google/parrot: make chromeos.c compilation conditional on CONFIG_CHROMEOS

No reason to compile/include chromeos.c for non-ChromeOS builds

Change-Id: Ie8ef1f4c521b2a7308941299f2501073937bdf4a
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
Reviewed-on: https://review.coreboot.org/19959
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/parrot/Makefile.inc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/google/parrot/Makefile.inc b/src/mainboard/google/parrot/Makefile.inc
index 78e5b98..a76bc12 100644
--- a/src/mainboard/google/parrot/Makefile.inc
+++ b/src/mainboard/google/parrot/Makefile.inc
@@ -15,6 +15,6 @@
 
 ramstage-y += ec.c
 
-romstage-y += chromeos.c
-ramstage-y += chromeos.c
+romstage-$(CONFIG_CHROMEOS) += chromeos.c
+ramstage-$(CONFIG_CHROMEOS) += chromeos.c
 romstage-y += gpio.c

-- 
To view, visit https://review.coreboot.org/19959
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8ef1f4c521b2a7308941299f2501073937bdf4a
Gerrit-Change-Number: 19959
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list