[coreboot-gerrit] Change in coreboot[master]: google/lulu: enable SATA device to sleep in S0

Martin Roth (Code Review) gerrit at coreboot.org
Sun Jun 4 18:41:27 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19957 )

Change subject: google/lulu: enable SATA device to sleep in S0
......................................................................

google/lulu: enable SATA device to sleep in S0

sata_devslp_disable was set to work around some buggy SSD
firmware, but as it's disabled by default in both Linux and
Windows, no reason to disable at the firmware level when
many properly-functioning SSDs can take advantage of power
savings.

Change-Id: Ib15f8b51db19b3d9d2e135f85c71a15a45a2ffbd
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
Reviewed-on: https://review.coreboot.org/19957
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/auron/variants/lulu/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/google/auron/variants/lulu/devicetree.cb b/src/mainboard/google/auron/variants/lulu/devicetree.cb
index 9f086a6..84fc8c4 100644
--- a/src/mainboard/google/auron/variants/lulu/devicetree.cb
+++ b/src/mainboard/google/auron/variants/lulu/devicetree.cb
@@ -43,7 +43,6 @@
 	register "gpe0_en_4" = "0x00000000"
 
 	register "sata_port_map" = "0x1"
-	register "sata_devslp_disable" = "1"
 
 	register "sio_acpi_mode" = "1"
 

-- 
To view, visit https://review.coreboot.org/19957
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib15f8b51db19b3d9d2e135f85c71a15a45a2ffbd
Gerrit-Change-Number: 19957
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list