[coreboot-gerrit] Change in coreboot[master]: superiotool: Add SMSC KBC1126

[Iru Cai (Code Review)]

Iru Cai has posted comments on this change. ( https://review.coreboot.org/18480 )

Change subject: superiotool: Add SMSC KBC1126
......................................................................


Patch Set 5:

> (2 comments)
 > 
 > I wonder what the differences of the KBC1126 and the KBC1122 are.
 > Only the LDN 0x10?

Oh, I missed LDN 0x10 in the datasheet (the datasheet has a mistake writing LDN 0xF is reserved but it says LDN 0x10 is reserved). LDN 0x10 is also not in kbc1100.h.

 > Have you read out the registers of the LDNs, that are marked as
 > reserved in the datasheet?
 > Since the datasheet of SCH3112/SCH3114/SCH3116 look like they might
 > contain the same silicon die, KBC1122 and KBC1126 might also be the
 > same silicon...

Actually I don't know anything about KBC1098/KBC11** except the things written in the KBC1122 datasheet. I haven't read out the LDNs said to be reserved yet.

-- 
To view, visit https://review.coreboot.org/18480
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id172ae42411a6d42a4ae7c7f30f96aeda3e6c384
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No