[coreboot-gerrit] Change in coreboot[master]: superiotool: Add SMSC KBC1126

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/18480 )

Change subject: superiotool: Add SMSC KBC1126
......................................................................


Patch Set 5:

(2 comments)

I wonder what the differences of the KBC1126 and the KBC1122 are. Only the LDN 0x10?
Have you read out the registers of the LDNs, that are marked as reserved in the datasheet?
Since the datasheet of SCH3112/SCH3114/SCH3116 look like they might contain the same silicon die, KBC1122 and KBC1126 might also be the same silicon...

https://review.coreboot.org/#/c/18480/5/util/superiotool/smsc.c
File util/superiotool/smsc.c:

PS5, Line 77: MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC
RSVD instead of MISC?


PS5, Line 92: 0x00
0x60


-- 
To view, visit https://review.coreboot.org/18480
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id172ae42411a6d42a4ae7c7f30f96aeda3e6c384
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes