[coreboot-gerrit] Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/20813 )

Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/Kconfig
File src/northbridge/intel/sandybridge/Kconfig:

https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/Kconfig@120
PS2, Line 120: 	default 0xf8000000 if USE_NATIVE_RAMINIT
this is inside the "if !USE_NATIVE_RAMINIT" block, so if I understand this right, this statement will never be used and MMCONF_BASE_ADDRESS will evaluate to 0.
also why don't we also use 0xf0000000 in the native raminit path?



-- 
To view, visit https://review.coreboot.org/20813
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978
Gerrit-Change-Number: 20813
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: James Ye <jye836 at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 29 Jul 2017 01:40:52 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170729/45e72e93/attachment.html>