<p>Felix Held <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20813">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/Kconfig">File src/northbridge/intel/sandybridge/Kconfig:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/Kconfig@120">Patch Set #2, Line 120:</a> <code style="font-family:monospace,monospace">   default 0xf8000000 if USE_NATIVE_RAMINIT</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this is inside the "if !USE_NATIVE_RAMINIT" block, so if I understand this right, this statement will never be used and MMCONF_BASE_ADDRESS will evaluate to 0.<br>also why don't we also use 0xf0000000 in the native raminit path?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20813">change 20813</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20813"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 </div>
<div style="display:none"> Gerrit-Change-Number: 20813 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: James Ye <jye836@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 29 Jul 2017 01:40:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>