[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20804 )

Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants/soraka/gpio.c
File src/mainboard/google/poppy/variants/soraka/gpio.c:

https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants/soraka/gpio.c@82
PS2, Line 82: 0
> It looks like this should be 1. WLAN_PE_RST_L is active low and so this sho
My bad! Looked at the schematics again and this is correct.



-- 
To view, visit https://review.coreboot.org/20804
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15
Gerrit-Change-Number: 20804
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Nicolas Boichat <drinkcat at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 28 Jul 2017 06:28:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170728/8f08fa3e/attachment.html>