<p>Furquan Shaikh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20804">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants/soraka/gpio.c">File src/mainboard/google/poppy/variants/soraka/gpio.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20804/2/src/mainboard/google/poppy/variants/soraka/gpio.c@82">Patch Set #2, Line 82:</a> <code style="font-family:monospace,monospace">0</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It looks like this should be 1. WLAN_PE_RST_L is active low and so this sho</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">My bad! Looked at the schematics again and this is correct.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20804">change 20804</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20804"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 </div>
<div style="display:none"> Gerrit-Change-Number: 20804 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 28 Jul 2017 06:28:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>