[coreboot-gerrit] Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8460p

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/20501 )

Change subject: mainboard/hp: Add HP Elitebook 8460p
......................................................................


Patch Set 6:

(3 comments)

With that fixed all boards seem ready to be pushed.

https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb
File src/mainboard/hp/8460p/devicetree.cb:

https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb@17
PS6, Line 17: chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did
remove all FIXMEs


https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb@18
PS6, Line 18: 	register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }"
last two elements can be removed ad gfx.ndid is 3


https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c
File src/mainboard/hp/8460p/romstage.c:

https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c@34
PS6, Line 34: {
On Ivybridge I've done:
RCBA32(FD) = PCH_DISABLE_ALWAYS | 0x10001fe0;
Bits that should be always disabled + reserved bits.
Applies to all boards.



-- 
To view, visit https://review.coreboot.org/20501
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604
Gerrit-Change-Number: 20501
Gerrit-PatchSet: 6
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 27 Jul 2017 15:39:41 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170727/381691ae/attachment.html>